What steps will reproduce the problem?
1. Build prosody from trunk or 0.10/tip on alpine Linux
2. Start in foreground
3. Stop with CTRL+C
What is the expected output?
A smooth shutdown
What do you see instead?
Nov 29 20:42:09 mod_posix info Received SIGINT
Nov 29 20:42:09 general info Shutting down: Received SIGINT
Nov 29 20:42:09 general error Top-level error, please report:
attempt to call a nil value
Nov 29 20:42:09 general error
stack traceback:
[C]: in function 'socket_select'
/usr/local/lib/prosody/net/server_select.lua:866: in function </usr/local/lib/prosody/net/server_select.lua:861>
[C]: in function 'xpcall'
/usr/local/bin/prosody:400: in function 'loop'
/usr/local/bin/prosody:431: in main chunk
[C]: ?
Nov 29 20:42:10 general info Shutting down...
Nov 29 20:42:10 general info Shutdown status: Cleaning up
Nov 29 20:42:10 general info Shutdown complete
What version of the product are you using? On what operating system?
Alpine Linux, build from hg
Problem with hg/changeset 7496:7ea3311ca632
Works nice with hg/changeset 7495:a9e8523a5e73
Please provide any additional information below.
Zash
on
Thanks for the report!
Looks like an incomplete change from counting downwards to counting upwards in that loop. Oddly enough, it doesn't seem to happen under Lua 5.2, which prevented me from reproducing at first.
Changes
owner Zash
tags Status-Accepted Milestone-0.10
title7ea3311ca632 introduces Problem during shutdown Error in signal handler dispatch
What steps will reproduce the problem? 1. Build prosody from trunk or 0.10/tip on alpine Linux 2. Start in foreground 3. Stop with CTRL+C What is the expected output? A smooth shutdown What do you see instead? Nov 29 20:42:09 mod_posix info Received SIGINT Nov 29 20:42:09 general info Shutting down: Received SIGINT Nov 29 20:42:09 general error Top-level error, please report: attempt to call a nil value Nov 29 20:42:09 general error stack traceback: [C]: in function 'socket_select' /usr/local/lib/prosody/net/server_select.lua:866: in function </usr/local/lib/prosody/net/server_select.lua:861> [C]: in function 'xpcall' /usr/local/bin/prosody:400: in function 'loop' /usr/local/bin/prosody:431: in main chunk [C]: ? Nov 29 20:42:10 general info Shutting down... Nov 29 20:42:10 general info Shutdown status: Cleaning up Nov 29 20:42:10 general info Shutdown complete What version of the product are you using? On what operating system? Alpine Linux, build from hg Problem with hg/changeset 7496:7ea3311ca632 Works nice with hg/changeset 7495:a9e8523a5e73 Please provide any additional information below.
Thanks for the report! Looks like an incomplete change from counting downwards to counting upwards in that loop. Oddly enough, it doesn't seem to happen under Lua 5.2, which prevented me from reproducing at first.
Changes7ea3311ca632 introduces Problem during shutdownError in signal handler dispatchFixed in https://hg.prosody.im/0.10/rev/fb27aff6d491
Changes